linux-kernel - Re: [PATCH] workqueue: Fix NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171026175558.GF59538@devbig577.frc2.facebook.com>
Date:   Thu, 26 Oct 2017 10:55:58 -0700
From:   Tejun Heo <tj@...nel.org>
To:     Lai Jiangshan <jiangshanlai@...il.com>
Cc:     Li Bin <huawei.libin@...wei.com>,
        LKML <linux-kernel@...r.kernel.org>, tanxiaofei@...wei.com,
        guohanjun@...wei.com
Subject: Re: [PATCH] workqueue: Fix NULL pointer dereference

Hello,

On Thu, Oct 26, 2017 at 11:55:00PM +0800, Lai Jiangshan wrote:
> I remember that softirq can be invoked when irq_eixt(),
> and in this case the current->current_pwq is also NULL
> if __queue_work() is called in the soft irq.
> 
> So in_task() might be better than !in_irq() for the fix?

Reverted the patch for now.  Li, what do you think?

Thanks.

-- 
tejun