linux-kernel - Re: [PATCH] staging: ccree: Fix indentation in ssi_buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 27 Oct 2017 11:32:47 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Stephen Brennan <stephen@...nnan.io>
Cc:     Gilad Ben-Yossef <gilad@...yossef.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-crypto@...r.kernel.org,
        driverdev-devel@...uxdriverproject.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: ccree: Fix indentation in ssi_buffer_mgr.c

On Thu, Oct 26, 2017 at 06:53:42PM -0700, Stephen Brennan wrote:
> In particular, fixes some over-indented if statement bodies as well as a
> couple lines indented with spaces. checkpatch.pl now reports no warnings
> on this file other than 80 character warnings.
> 
> Signed-off-by: Stephen Brennan <stephen@...nnan.io>
> ---
> Hello again, hoping these indentation issues are a bit more actionable than the
> line length errors I was trying to fix in my previous patch. Again, thanks in
> advance for taking the time to look!
> 
>  drivers/staging/ccree/ssi_buffer_mgr.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/ccree/ssi_buffer_mgr.c b/drivers/staging/ccree/ssi_buffer_mgr.c
> index dca3ce84d043..7c62255128d5 100644
> --- a/drivers/staging/ccree/ssi_buffer_mgr.c
> +++ b/drivers/staging/ccree/ssi_buffer_mgr.c
> @@ -406,8 +406,8 @@ ssi_aead_handle_config_buf(struct device *dev,
>  	sg_init_one(&areq_ctx->ccm_adata_sg, config_data, AES_BLOCK_SIZE + areq_ctx->ccm_hdr_size);
>  	if (unlikely(dma_map_sg(dev, &areq_ctx->ccm_adata_sg, 1,
>  				DMA_TO_DEVICE) != 1)) {
> -			dev_err(dev, "dma_map_sg() config buffer failed\n");
> -			return -ENOMEM;
> +		dev_err(dev, "dma_map_sg() config buffer failed\n");
> +		return -ENOMEM;
>  	}
>  	dev_dbg(dev, "Mapped curr_buff: dma_address=%pad page=%p addr=%pK offset=%u length=%u\n",
>  		&sg_dma_address(&areq_ctx->ccm_adata_sg),
> @@ -435,8 +435,8 @@ static inline int ssi_ahash_handle_curr_buf(struct device *dev,
>  	sg_init_one(areq_ctx->buff_sg, curr_buff, curr_buff_cnt);
>  	if (unlikely(dma_map_sg(dev, areq_ctx->buff_sg, 1,
>  				DMA_TO_DEVICE) != 1)) {
> -			dev_err(dev, "dma_map_sg() src buffer failed\n");
> -			return -ENOMEM;
> +		dev_err(dev, "dma_map_sg() src buffer failed\n");
> +		return -ENOMEM;

So far so good.

>  	}
>  	dev_dbg(dev, "Mapped curr_buff: dma_address=%pad page=%p addr=%pK offset=%u length=%u\n",
>  		&sg_dma_address(areq_ctx->buff_sg), sg_page(areq_ctx->buff_sg),
> @@ -1029,10 +1029,10 @@ static inline int ssi_buffer_mgr_prepare_aead_data_mlli(
>  			 * verification is made by CPU compare in order to simplify
>  			 * MAC verification upon request completion
>  			 */
> -			  u32 size_to_skip = req->assoclen;
> +			u32 size_to_skip = req->assoclen;
>  
> -			  if (areq_ctx->is_gcm4543)
> -				  size_to_skip += crypto_aead_ivsize(tfm);
> +			if (areq_ctx->is_gcm4543)
> +				size_to_skip += crypto_aead_ivsize(tfm);
>  
>  			  ssi_buffer_mgr_copy_scatterlist_portion(
>  				dev, areq_ctx->backup_mac, req->src,

But then ssi_buffer_mgr_copy_scatterlist_portion() is still not indented
correctly.

regards,
dan carpenter