linux-kernel - Re: [PATCH] staging: ccree: Fix indentation in ssi_buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 27 Oct 2017 07:23:58 -0700
From:   Joe Perches <joe@...ches.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Stephen Brennan <stephen@...nnan.io>
Cc:     Gilad Ben-Yossef <gilad@...yossef.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-crypto@...r.kernel.org,
        driverdev-devel@...uxdriverproject.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: ccree: Fix indentation in ssi_buffer_mgr.c

On Fri, 2017-10-27 at 11:32 +0300, Dan Carpenter wrote:
> On Thu, Oct 26, 2017 at 06:53:42PM -0700, Stephen Brennan wrote:
> > In particular, fixes some over-indented if statement bodies as well as a
> > couple lines indented with spaces. checkpatch.pl now reports no warnings
> > on this file other than 80 character warnings.
[]
> > diff --git a/drivers/staging/ccree/ssi_buffer_mgr.c b/drivers/staging/ccree/ssi_buffer_mgr.c
[]
> > @@ -1029,10 +1029,10 @@ static inline int ssi_buffer_mgr_prepare_aead_data_mlli(
> >  			 * verification is made by CPU compare in order to simplify
> >  			 * MAC verification upon request completion
> >  			 */
> > -			  u32 size_to_skip = req->assoclen;
> > +			u32 size_to_skip = req->assoclen;
> >  
> > -			  if (areq_ctx->is_gcm4543)
> > -				  size_to_skip += crypto_aead_ivsize(tfm);
> > +			if (areq_ctx->is_gcm4543)
> > +				size_to_skip += crypto_aead_ivsize(tfm);
> >  
> >  			  ssi_buffer_mgr_copy_scatterlist_portion(
> >  				dev, areq_ctx->backup_mac, req->src,
> 
> But then ssi_buffer_mgr_copy_scatterlist_portion() is still not indented
> correctly.

The latest version of checkpatch should bleat something on the
	...scatterlist_portion(
line