linux-kernel - Re: [PATCH 2/4] m68k/mac: Disentangle VIA and OSS initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 27 Oct 2017 13:02:59 +0200
From:   Kars de Jong <jongk@...ux-m68k.org>
To:     Finn Thain <fthain@...egraphics.com.au>
Cc:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        linux-m68k@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] m68k/mac: Disentangle VIA and OSS initialization

2017-10-27 4:45 GMT+02:00 Finn Thain <fthain@...egraphics.com.au>:
> macintosh_config->via_type is meaningless on Mac IIfx (i.e. the only
> model with OSS chip), so skip the via_type switch statement.
>
> Call oss_init() before via_init() because it is more important and
> because that is the right place to initialize the oss_present flag.
>
> On this model, bringing forward oss_init() and delaying via_init()
> is no problem because those functions are independent.
>
> The only requirement here is that oss_register_interrupts() happens
> after via_init(). That is, mac_init_IRQ() happens after config_mac().
>
> Tested-by: Stan Johnson <userm57@...oo.com>

Was this tested on a Mac IIfx and on at least one other Mac?

> Signed-off-by: Finn Thain <fthain@...egraphics.com.au>

Reviewed-by: Kars de Jong <jongk@...ux-m68k.org>

(Geert, Finn: sorry about the spam. Bloody Gmail...)

Kars.