linux-kernel - Re: [PATCH 2/2] IB/rxe: don't crash, if allocation of crc algorithm failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAG9sBKPvK95UpxS_4SO0WxJuCyYrjAhe=Am-Ev2Kp+mQFxyYhA@mail.gmail.com>
Date:   Sun, 29 Oct 2017 10:20:18 +0300
From:   Moni Shoua <monis@...lanox.com>
To:     Thomas Bogendoerfer <tbogendoerfer@...e.de>
Cc:     Doug Ledford <dledford@...hat.com>,
        linux-rdma <linux-rdma@...r.kernel.org>,
        Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] IB/rxe: don't crash, if allocation of crc algorithm failed

On Fri, Oct 27, 2017 at 6:59 PM, Thomas Bogendoerfer
<tbogendoerfer@...e.de> wrote:
> Following crash happens, if crc algorithm couldn't be allocated:
>
> [ 1087.989072] rdma_rxe: loaded
> [ 1097.855397] PCLMULQDQ-NI instructions are not detected.
> [ 1097.901220] rdma_rxe: failed to allocate crc algorithmi err:-2
> [ 1097.901248] BUG: unable to handle kernel
> [ 1097.901249] NULL pointer dereference
> [ 1097.901250]  at 0000000000000046
> [...]
>
> Reason is that rxe->tfm is assigned the error return, which will then
> be used for crypto_free_shash() in rxe_cleanup. Fix by using a
> temporay variable and assigning it rxe->tfm after allocation succeeded.
>
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@...e.de>
Fix looks good only a Fixes line is missing from the commit message. Please add.