linux-kernel - Re: [PATCH 2/2] IB/rxe: don't crash, if allocation of crc algorithm failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171029090027.GL16127@mtr-leonro.local>
Date:   Sun, 29 Oct 2017 11:00:27 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Moni Shoua <monis@...lanox.com>
Cc:     Thomas Bogendoerfer <tbogendoerfer@...e.de>,
        Doug Ledford <dledford@...hat.com>,
        linux-rdma <linux-rdma@...r.kernel.org>,
        Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] IB/rxe: don't crash, if allocation of crc algorithm
 failed

On Sun, Oct 29, 2017 at 10:20:18AM +0300, Moni Shoua wrote:
> On Fri, Oct 27, 2017 at 6:59 PM, Thomas Bogendoerfer
> <tbogendoerfer@...e.de> wrote:
> > Following crash happens, if crc algorithm couldn't be allocated:
> >
> > [ 1087.989072] rdma_rxe: loaded
> > [ 1097.855397] PCLMULQDQ-NI instructions are not detected.
> > [ 1097.901220] rdma_rxe: failed to allocate crc algorithmi err:-2
> > [ 1097.901248] BUG: unable to handle kernel
> > [ 1097.901249] NULL pointer dereference
> > [ 1097.901250]  at 0000000000000046
> > [...]
> >
> > Reason is that rxe->tfm is assigned the error return, which will then
> > be used for crypto_free_shash() in rxe_cleanup. Fix by using a
> > temporay variable and assigning it rxe->tfm after allocation succeeded.
> >
> > Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@...e.de>
> Fix looks good only a Fixes line is missing from the commit message. Please add.

temporay -> temporary

Thanks

> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)