linux-kernel - Re: [PATCH v3] KVM: arm/arm64: fix the incompatible matching for external abort

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <861slmaha7.fsf@arm.com>
Date:   Sun, 29 Oct 2017 01:12:32 +0000
From:   Marc Zyngier <marc.zyngier@....com>
To:     Dongjiu Geng <gengdongjiu@...wei.com>
Cc:     <christoffer.dall@...aro.org>, <linux@...linux.org.uk>,
        <catalin.marinas@....com>, <will.deacon@....com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <kvmarm@...ts.cs.columbia.edu>, <linux-kernel@...r.kernel.org>,
        <huangshaoyu@...wei.com>, <wuquanming@...wei.com>
Subject: Re: [PATCH v3] KVM: arm/arm64: fix the incompatible matching for external abort

On Sat, Oct 28 2017 at  2:45:59 pm BST, Dongjiu Geng <gengdongjiu@...wei.com> wrote:
> For this matching, switch expression uses fault type which is
> not {I,D}FSC value, but the case expression uses {I,D}FSC,
> they are incompatible. So change the switch expression to
> use {I,D}FSC.

I'm sorry, but I can't manage to parse this commit message. How about
something like this?

"kvm_vcpu_dabt_isextabt() tries to match a full fault syndrome, but
 calls kvm_vcpu_trap_get_fault_type() that only returns the fault class,
 thus reducing the scope of the check. This doesn't cause any observable
 bug yet as we end-up matching a closely related syndrome for which we
 return the same value.

 Using kvm_vcpu_trap_get_fault() instead fixes it for good"

Otherwise:

Acked-by: Marc Zyngier <marc.zyngier@....com>

	M.
-- 
Jazz is not dead. It just smells funny.