linux-kernel - Re: [PATCH v3] KVM: arm/arm64: fix the incompatible matching for external abort

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b3d95d31-acbc-3ab4-f828-bcbb2280a198@huawei.com>
Date:   Mon, 30 Oct 2017 09:13:22 +0800
From:   gengdongjiu <gengdongjiu@...wei.com>
To:     Marc Zyngier <marc.zyngier@....com>
CC:     <christoffer.dall@...aro.org>, <linux@...linux.org.uk>,
        <catalin.marinas@....com>, <will.deacon@....com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <kvmarm@...ts.cs.columbia.edu>, <linux-kernel@...r.kernel.org>,
        <huangshaoyu@...wei.com>, <wuquanming@...wei.com>
Subject: Re: [PATCH v3] KVM: arm/arm64: fix the incompatible matching for
 external abort


On 2017/10/29 9:12, Marc Zyngier wrote:
> I'm sorry, but I can't manage to parse this commit message. How about
> something like this?
> 
> "kvm_vcpu_dabt_isextabt() tries to match a full fault syndrome, but
>  calls kvm_vcpu_trap_get_fault_type() that only returns the fault class,
>  thus reducing the scope of the check. This doesn't cause any observable
>  bug yet as we end-up matching a closely related syndrome for which we
>  return the same value.
> 
>  Using kvm_vcpu_trap_get_fault() instead fixes it for good"

Marc, thank you very much for your pointing out and good suggestion,
will update it. Thanks a lot.