linux-kernel - Re: [PATCH v2 1/2] media: i2c: Add the ov7740 image sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201710301443.I7CA4dcJ%fengguang.wu@intel.com>
Date:   Mon, 30 Oct 2017 14:57:00 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Wenyou Yang <wenyou.yang@...rochip.com>
Cc:     kbuild-all@...org,
        Mauro Carvalho Chehab <mchehab@...pensource.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-kernel@...r.kernel.org,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        devicetree@...r.kernel.org, Sakari Ailus <sakari.ailus@....fi>,
        Jonathan Corbet <corbet@....net>,
        Hans Verkuil <hverkuil@...all.nl>,
        linux-arm-kernel@...ts.infradead.org,
        Linux Media Mailing List <linux-media@...r.kernel.org>,
        Wenyou Yang <wenyou.yang@...rochip.com>,
        Songjun Wu <songjun.wu@...rochip.com>
Subject: Re: [PATCH v2 1/2] media: i2c: Add the ov7740 image sensor driver

Hi Wenyou,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.14-rc7 next-20171018]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Wenyou-Yang/media-i2c-Add-the-ov7740-image-sensor-driver/20171030-140347
base:   git://linuxtv.org/media_tree.git master
config: blackfin-allyesconfig (attached as .config)
compiler: bfin-uclinux-gcc (GCC) 6.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=blackfin 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   In file included from drivers/media//i2c/ov7740.c:21:0:
   drivers/media//i2c/ov7740.c: In function 'ov7740_set_ctrl':
>> include/linux/regmap.h:73:2: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized]
     regmap_update_bits_base(map, reg, mask, val, NULL, false, false)
     ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/media//i2c/ov7740.c:512:5: note: 'val' was declared here
     u8 val;
        ^~~
--
   In file included from drivers/media/i2c/ov7740.c:21:0:
   drivers/media/i2c/ov7740.c: In function 'ov7740_set_ctrl':
>> include/linux/regmap.h:73:2: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized]
     regmap_update_bits_base(map, reg, mask, val, NULL, false, false)
     ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/media/i2c/ov7740.c:512:5: note: 'val' was declared here
     u8 val;
        ^~~

vim +/val +73 include/linux/regmap.h

8019ff6cf Nariman Poushin   2015-07-16  71  
ca7a94464 Kuninori Morimoto 2016-02-15  72  #define	regmap_update_bits(map, reg, mask, val) \
ca7a94464 Kuninori Morimoto 2016-02-15 @73  	regmap_update_bits_base(map, reg, mask, val, NULL, false, false)
30ed9cb7a Kuninori Morimoto 2016-02-15  74  #define	regmap_update_bits_async(map, reg, mask, val)\
30ed9cb7a Kuninori Morimoto 2016-02-15  75  	regmap_update_bits_base(map, reg, mask, val, NULL, true, false)
98c2dc486 Kuninori Morimoto 2016-02-15  76  #define	regmap_update_bits_check(map, reg, mask, val, change)\
98c2dc486 Kuninori Morimoto 2016-02-15  77  	regmap_update_bits_base(map, reg, mask, val, change, false, false)
89d8d4b83 Kuninori Morimoto 2016-02-15  78  #define	regmap_update_bits_check_async(map, reg, mask, val, change)\
89d8d4b83 Kuninori Morimoto 2016-02-15  79  	regmap_update_bits_base(map, reg, mask, val, change, true, false)
ca7a94464 Kuninori Morimoto 2016-02-15  80  

:::::: The code at line 73 was first introduced by commit
:::::: ca7a94464b5457a8dc5add19f6fc3bea59d6193f regmap: merge regmap_update_bits() into macro

:::::: TO: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
:::::: CC: Mark Brown <broonie@...nel.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (46053 bytes)