linux-kernel - Re: [PATCH] platform: x86: dell-smo8800: remove redundant assignments to byte

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171031141351.yrjhwweubwxptb4j@pali>
Date:   Tue, 31 Oct 2017 15:13:51 +0100
From:   Pali Rohár <pali.rohar@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Colin King <colin.king@...onical.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform: x86: dell-smo8800: remove redundant
 assignments to byte_data

On Tuesday 31 October 2017 16:07:25 Andy Shevchenko wrote:
> On Tue, Oct 31, 2017 at 3:55 PM, Pali Rohár <pali.rohar@...il.com> wrote:
> > On Tuesday 31 October 2017 15:47:58 Andy Shevchenko wrote:
> >> On Tue, Oct 31, 2017 at 1:03 PM, Colin King <colin.king@...onical.com> wrote:
> >> > From: Colin Ian King <colin.king@...onical.com>
> >> >
> >> > Variable byte_data is being initialized and re-assigned with values that
> >> > are never read. Remove these as these redundant assignments. Cleans up
> >> > clang warning:
> >> >
> >> > drivers/platform/x86/dell-smo8800.c:106:2: warning: Value stored to 'byte_data'
> >> > is never read
> >>
> >> Thanks for the patch.
> >>
> >> As I read a code it was from the beginning like this. I dunno what was
> >> a motivation of this pieces, thus I would like to hear Pali.
> >
> > IIRC this part of code comes from the lis3lv* driver which was used for
> > HP EliteBook machines. As both drivers provides similar interface for
> > userspace.
> 
> OK, though it doesn't clarify the intention of the byte_data
> (useless?) assignments.

Probably similar code pattern exists in that lis3lv* driver...

-- 
Pali Rohár
pali.rohar@...il.com