linux-kernel - Re: [PATCH] Sony-laptop: Use common error handling code in sony_nc_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 31 Oct 2017 18:35:02 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     Platform Driver <platform-driver-x86@...r.kernel.org>,
        Andy Shevchenko <andy@...radead.org>,
        Darren Hart <dvhart@...radead.org>,
        Mattia Dongili <malattia@...ux.it>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] Sony-laptop: Use common error handling code in sony_nc_setup_rfkill()

On Tue, Oct 31, 2017 at 4:24 PM, SF Markus Elfring
<elfring@...rs.sourceforge.net> wrote:
>> Apparently this patch done without reading the actual code.
>
> I performed another simple software refactoring.

Which is _useless_ per se by the reasons you had been told already
_several_ times about.

Either you do a real fix (propagate correct error codes to upper
layers), or just don't bother at all.

>> NAK.

-- 
With Best Regards,
Andy Shevchenko