linux-kernel - Re: Sony-laptop: Use common error handling code in sony_nc_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 31 Oct 2017 17:56:21 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Andy Shevchenko <andy.shevchenko@...il.com>,
        platform-driver-x86@...r.kernel.org
Cc:     Andy Shevchenko <andy@...radead.org>,
        Darren Hart <dvhart@...radead.org>,
        Mattia Dongili <malattia@...ux.it>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: Sony-laptop: Use common error handling code in
 sony_nc_setup_rfkill()

>> I performed another simple software refactoring.
> 
> Which is _useless_ per se

I disagree in this case because the goal of a refactoring should be
to adjust something in a desired direction without changing
the provided functionality.

> by the reasons you had been told already _several_ times about.

There can be other reasons why you do not like a concrete change.

> Either you do a real fix (propagate correct error codes
> to upper layers), or just don't bother at all.

Have the involved contributors any preferences on organisation
of corresponding update steps?

* Correct exception handling first and then apply the shown
  source code reduction again.

* Combine better exception handling with smaller code
  in one patch.

* Addition of the tag “Fixes” in the commit message?

Regards,
Markus