linux-kernel - Re: [PATCH] scsi: qla2xxx: Convert timers to use timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16733DFA-7339-4F77-9125-E8845C4FCD6F@cavium.com>
Date:   Tue, 31 Oct 2017 18:03:45 +0000
From:   "Madhani, Himanshu" <Himanshu.Madhani@...ium.com>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>
CC:     Kees Cook <keescook@...omium.org>,
        Dept-Eng QLA2xxx Upstream <qla2xxx-upstream@...ium.com>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup()

Hi Martin/Kees, 

> On Oct 31, 2017, at 8:49 AM, Martin K. Petersen <martin.petersen@...cle.com> wrote:
> 
> 
> Kees,
> 
>> In preparation for unconditionally passing the struct timer_list
>> pointer to all timer callbacks, switch to using the new timer_setup()
>> and from_timer() to pass the timer pointer explicitly.
> 
> Cavium folks: Please verify!
> 

I’ve checked on my setup and i am seeing regression with this patch applied. 

Driver load locks up the system with this patch applied. 

NACK 

> Reviewed-by: Martin K. Petersen <martin.petersen@...cle.com>
> 
> -- 
> Martin K. Petersen	Oracle Linux Engineering

Thanks,
- Himanshu