linux-kernel - Re: [PATCH] scsi: qla2xxx: Convert timers to use timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1509473546.12927.5.camel@wdc.com>
Date:   Tue, 31 Oct 2017 18:12:27 +0000
From:   Bart Van Assche <Bart.VanAssche@....com>
To:     "Himanshu.Madhani@...ium.com" <Himanshu.Madhani@...ium.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC:     "keescook@...omium.org" <keescook@...omium.org>,
        "jejb@...ux.vnet.ibm.com" <jejb@...ux.vnet.ibm.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "qla2xxx-upstream@...ium.com" <qla2xxx-upstream@...ium.com>
Subject: Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup()

On Tue, 2017-10-31 at 18:03 +0000, Madhani, Himanshu wrote:
> On Oct 31, 2017, at 8:49 AM, Martin K. Petersen <martin.petersen@...cle.com> wrote:
> > > In preparation for unconditionally passing the struct timer_list
> > > pointer to all timer callbacks, switch to using the new timer_setup()
> > > and from_timer() to pass the timer pointer explicitly.
> > 
> > Cavium folks: Please verify!
> 
> I’ve checked on my setup and i am seeing regression with this patch applied. 
> 
> Driver load locks up the system with this patch applied. 
> 
> NACK 

That feedback is not very helpful ...

Anyway, what kernel source tree did you use in your testing? I may be able to
free up some time to look into this myself.

Bart.