linux-kernel - Re: [PATCH] scsi: sas: Convert timers to use timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 31 Oct 2017 18:13:14 +0000
From:   John Garry <john.garry@...wei.com>
To:     Kees Cook <keescook@...omium.org>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
CC:     "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        Jack Wang <jinpu.wang@...fitbricks.com>,
        "lindar_liu@...sh.com" <lindar_liu@...sh.com>,
        Jens Axboe <axboe@...com>, Hannes Reinecke <hare@...e.com>,
        "Johannes Thumshirn" <jthumshirn@...e.de>,
        Benjamin Block <bblock@...ux.vnet.ibm.com>,
        Baoyou Xie <baoyou.xie@...aro.org>,
        "weiyongjun (A)" <weiyongjun1@...wei.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linuxarm <linuxarm@...wei.com>
Subject: Re: [PATCH] scsi: sas: Convert timers to use timer_setup()

On 25/10/2017 11:08, Kees Cook wrote:
> In preparation for unconditionally passing the struct timer_list pointer to
> all timer callbacks, switch to using the new timer_setup() and from_timer()
> to pass the timer pointer explicitly. This requires adding a pointer to
> hold the timer's target task, as there isn't a link back from slow_task.
>
> Cc: John Garry <john.garry@...wei.com>
> Cc: "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>
> Cc: "Martin K. Petersen" <martin.petersen@...cle.com>
> Cc: Jack Wang <jinpu.wang@...fitbricks.com>
> Cc: lindar_liu@...sh.com
> Cc: Jens Axboe <axboe@...com>
> Cc: Hannes Reinecke <hare@...e.com>
> Cc: Johannes Thumshirn <jthumshirn@...e.de>
> Cc: Benjamin Block <bblock@...ux.vnet.ibm.com>
> Cc: Baoyou Xie <baoyou.xie@...aro.org>
> Cc: Wei Yongjun <weiyongjun1@...wei.com>
> Cc: linux-scsi@...r.kernel.org
> Signed-off-by: Kees Cook <keescook@...omium.org>

Acked-by: John Garry <john.garry@...wei.com> #for hisi_sas part
Tested-by: John Garry <john.garry@...wei.com> # basic sanity test for 
hisi_sas (+ libsas)

> ---
>  drivers/scsi/hisi_sas/hisi_sas.h       |  1 -
>  drivers/scsi/hisi_sas/hisi_sas_main.c  | 14 ++++++--------
>  drivers/scsi/hisi_sas/hisi_sas_v1_hw.c |  6 +++---
>  drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 24 +++++++++++-------------
>  drivers/scsi/hisi_sas/hisi_sas_v3_hw.c |  2 +-
>  drivers/scsi/libsas/sas_expander.c     |  8 ++++----
>  drivers/scsi/libsas/sas_init.c         |  3 ++-
>  drivers/scsi/libsas/sas_scsi_host.c    |  2 +-
>  drivers/scsi/mvsas/mv_init.c           |  3 +--
>  drivers/scsi/mvsas/mv_sas.c            | 15 +++++++--------
>  drivers/scsi/mvsas/mv_sas.h            |  1 -
>  drivers/scsi/pm8001/pm8001_sas.c       | 11 +++++------
>  include/scsi/libsas.h                  |  1 +
>  13 files changed, 42 insertions(+), 49 deletions(-)