lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 1 Nov 2017 10:09:53 +0000
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Andrew Jeffery <andrew@...id.au>
CC:     <linux-gpio@...r.kernel.org>, <linus.walleij@...aro.org>,
        <robh+dt@...nel.org>, <mark.rutland@....com>,
        <frowand.list@...il.com>, <joel@....id.au>,
        <ckeepax@...nsource.wolfsonmicro.com>, <ldewangan@...dia.com>,
        <ryan_chen@...eedtech.com>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <openbmc@...ts.ozlabs.org>,
        <linux-aspeed@...ts.ozlabs.org>
Subject: Re: [PATCH v3 1/2] gpio: gpiolib: Generalise state persistence
 beyond sleep

On Wed, Nov 01, 2017 at 03:04:56PM +1100, Andrew Jeffery wrote:
> General support for state persistence is added to gpiolib with the
> introduction of a new pinconf parameter to propagate the request to
> hardware. The existing persistence support for sleep is adapted to
> include hardware support if the GPIO driver provides it. Persistence
> continues to be enabled by default; in-kernel consumers can opt out, but
> userspace (currently) does not have a choice.
> 
> The *_SLEEP_MAY_LOSE_VALUE and *_SLEEP_MAINTAIN_VALUE symbols are
> renamed, dropping the SLEEP prefix to reflect that the concept is no
> longer sleep-specific.  I feel that renaming to just *_MAY_LOSE_VALUE
> could initially be misinterpreted, so I've further changed the symbols
> to *_TRANSITORY and *_PERSISTENT to address this.
> 
> The sysfs interface is modified only to keep consistency with the
> chardev interface in enforcing persistence for userspace exports.
> 
> Signed-off-by: Andrew Jeffery <andrew@...id.au>
> ---

Reviewed-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles

Powered by blists - more mailing lists