lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 1 Nov 2017 13:14:32 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Jiri Olsa <jolsa@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>, kernel-team@....com,
        Jin Yao <yao.jin@...ux.intel.com>,
        Milian Wolff <milian.wolff@...b.com>
Subject: Re: [PATCH 2/2] perf tools: Show correct function name for srcline
 of callchains

On Tue, Oct 31, 2017 at 11:06:54AM +0900, Namhyung Kim wrote:
> When libbfd is not used, it doesn't show proper function name and reuse
> the original symbol of the sample.  That's because it passes the
> original sym to inline_list__append().  As `addr2line -f` returns
> function names as well, use that to create ad inline_sym and pass it to
> inline_list__append().
> 
> For example, following data shows that inlined entries of main have same
> name (main).
> 
> Before:
>   $ perf report -g srcline -q | head
>       45.22%  inlining     libm-2.26.so      [.] __hypot_finite
>               |
>               ---__hypot_finite ??:0
>                  |
>                  |--44.15%--hypot ??:0
>                  |          main complex:589
>                  |          main complex:597
>                  |          main complex:654
>                  |          main complex:664
>                  |          main inlining.cpp:14
> 
> After:
>   $ perf report -g srcline -q | head
>       45.22%  inlining     libm-2.26.so      [.] __hypot_finite
>               |
>               ---__hypot_finite
>                  |
>                  |--44.15%--hypot
>                  |          std::__complex_abs complex:589 (inlined)
>                  |          std::abs<double> complex:597 (inlined)
>                  |          std::_Norm_helper<true>::_S_do_it<double> complex:654 (inlined)
>                  |          std::norm<double> complex:664 (inlined)
>                  |          main inlining.cpp:14
> 
> Cc: Jin Yao <yao.jin@...ux.intel.com>
> Cc: Milian Wolff <milian.wolff@...b.com>
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>

looks ok

Reviewed-by: Jiri Olsa <jolsa@...nel.org>

jirka

Powered by blists - more mailing lists