lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 1 Nov 2017 15:18:59 +0100 From: Ulf Hansson <ulf.hansson@...aro.org> To: Doug Anderson <dianders@...omium.org> Cc: Shawn Lin <shawn.lin@...k-chips.com>, Jaehoon Chung <jh80.chung@...sung.com>, Ziyuan Xu <xzy.xu@...k-chips.com>, Alexandru Stan <amstan@...omium.org>, "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>, Brian Norris <briannorris@...omium.org>, linux-samsung-soc <linux-samsung-soc@...r.kernel.org>, Emil Renner Berthing <kernel@...il.dk>, "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2 0/5] mmc: dw_mmc: Fix the CTO timer patch, plus the DTO timer On 31 October 2017 at 19:14, Doug Anderson <dianders@...omium.org> wrote: > Hi, > > On Tue, Oct 31, 2017 at 12:05 AM, Shawn Lin <shawn.lin@...k-chips.com> wrote: >> Hi Ulf, >> >> >> On 2017/10/30 19:40, Ulf Hansson wrote: >>> >>> On 12 October 2017 at 22:11, Douglas Anderson <dianders@...omium.org> >>> wrote: >>>> >>>> Recently we landed 03de19212ea3 ("mmc: dw_mmc: introduce timer for >>>> broken command transfer over scheme"). I found a bunch of problems >>>> with that patch, so this series attempts to solve some of them. >>>> >>>> This also fixes the DTO timer in some of the same ways even though I >>>> haven't personally seen problems with the DTO timer. >>>> >>>> NOTE: this series has only been lighly tested so far. I can at least >>>> reproduce the need for the CTO timer on one of my devices and so I can >>>> confirm that part still works. As mentioned in the 3rd patch I also >>>> ran the mmc_test kernel module on this and did manage to see the 3rd >>>> patch doing something useful. >>>> >>>> Changes in v2: >>>> - Removed extra "int i" >>>> - Fix the DTO timeout calculation new for v2 >>>> - Cleanup the DTO timer new for v2 >>>> >>>> Douglas Anderson (5): >>>> mmc: dw_mmc: cancel the CTO timer after a voltage switch >>>> mmc: dw_mmc: Fix the CTO timeout calculation >>>> mmc: dw_mmc: Add locking to the CTO timer >>>> mmc: dw_mmc: Fix the DTO timeout calculation >>>> mmc: dw_mmc: Cleanup the DTO timer like the CTO one >>>> >>>> drivers/mmc/host/dw_mmc.c | 162 >>>> +++++++++++++++++++++++++++++++++++++++++----- >>>> 1 file changed, 146 insertions(+), 16 deletions(-) >>>> >>> >>> Douglas, Jaehoon, >>> >>> I decided to pick patch 1->4 for fixes and the patch 5 for next, that >>> should help us to get them more tested, while Jaehoon is still >>> catching up. >>> >>> I can add ack/drop patches for yet a couple of days this week. >> >> >> Patch 4 introduce a warning: >> >> warning: unused variable ‘irqflags’ [-Wunused-variable] >> >> irqflags should be introduced in patch 5 in the same place. >> As it seems patch 5 will be candidate for 4.15, so could you please >> help fix patch 4 and 5 manually? Or Doug need to resend patch 4 and 5? > > Thanks for catching this and sorry for the dumb screwup. Ulf: I'm > happy to do do whatever makes it easiest for you. If you want me to > re-post it should be very quick. I fixed it myself, by amending the commits, no worries this time! Kind regards Uffe
Powered by blists - more mailing lists