[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <B3182102-F96B-4579-9CC6-3F8F73C442E5@durin42.com>
Date: Wed, 1 Nov 2017 16:05:13 -0400
From: Augie Fackler <raf@...in42.com>
To: Tom Saeger <tom.saeger@...cle.com>
Cc: Joe Perches <joe@...ches.com>,
xen-devel <xen-devel@...ts.xenproject.org>,
mercurial-devel@...curial-scm.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts: warn about invalid MAINTAINERS patterns
> On Nov 1, 2017, at 13:11, Tom Saeger <tom.saeger@...cle.com> wrote:
>
> On Wed, Nov 01, 2017 at 09:50:05AM -0700, Joe Perches wrote:
>> (add mercurial-devel and xen-devel to cc's)
>>
>> On Tue, 2017-10-31 at 16:37 -0500, Tom Saeger wrote:
>>> Add "--pattern-checks" option to get_maintainer.pl to warn about invalid
>>> "F" and "X" patterns found in MAINTAINERS file(s).
>>
>> Hey again Tom.
>>
>> About mercurial/hg.
>>
>> While as far as I know there hasn't been a mercurial tree
>> for the linux kernel sources in many years, I believe the
>> mercurial command to list files should be different.
>>
>>> my %VCS_cmds_hg = (
>>> @@ -167,6 +169,7 @@ my %VCS_cmds_hg = (
>>> "subject_pattern" => "^HgSubject: (.*)",
>>> "stat_pattern" => "^(\\d+)\t(\\d+)\t\$file\$",
>>> "file_exists_cmd" => "hg files \$file",
>>> + "list_files_cmd" => "hg files \$file",
>>
>> I think this should be
>>
>> "list_files_cmd" => "hg manifest -R \$file",
>
> Ok - I'll add to v2.
Actually, I'd recommend `hg files` over `hg manifest` by a wide margin.
>
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@...curial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists