linux-kernel - Re: [PATCH] scripts: warn about invalid MAINTAINERS patterns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1509567842.31043.59.camel@perches.com>
Date:   Wed, 01 Nov 2017 13:24:02 -0700
From:   Joe Perches <joe@...ches.com>
To:     Augie Fackler <raf@...in42.com>, Tom Saeger <tom.saeger@...cle.com>
Cc:     xen-devel <xen-devel@...ts.xenproject.org>,
        mercurial-devel@...curial-scm.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts: warn about invalid MAINTAINERS patterns

On Wed, 2017-11-01 at 16:05 -0400, Augie Fackler wrote:
> > On Nov 1, 2017, at 13:11, Tom Saeger <tom.saeger@...cle.com> wrote:
> > 
> > On Wed, Nov 01, 2017 at 09:50:05AM -0700, Joe Perches wrote:
> > > (add mercurial-devel and xen-devel to cc's)
> > > 
> > > On Tue, 2017-10-31 at 16:37 -0500, Tom Saeger wrote:
> > > > Add "--pattern-checks" option to get_maintainer.pl to warn about invalid
> > > > "F" and "X" patterns found in MAINTAINERS file(s).
> > > 
> > > Hey again Tom.
> > > 
> > > About mercurial/hg.
> > > 
> > > While as far as I know there hasn't been a mercurial tree
> > > for the linux kernel sources in many years, I believe the
> > > mercurial command to list files should be different.
> > > 
> > > > my %VCS_cmds_hg = (
> > > > @@ -167,6 +169,7 @@ my %VCS_cmds_hg = (
> > > >     "subject_pattern" => "^HgSubject: (.*)",
> > > >     "stat_pattern" => "^(\\d+)\t(\\d+)\t\$file\$",
> > > >     "file_exists_cmd" => "hg files \$file",
> > > > +    "list_files_cmd" => "hg files \$file",
> > > 
> > > I think this should be
> > > 
> > > 	"list_files_cmd" => "hg manifest -R \$file",
> > 
> > Ok - I'll add to v2.
> 
> Actually, I'd recommend `hg files` over `hg manifest` by a wide margin.

why?

hg files -R <path> prefixes all the output
hg manifest -R <path> output is unprefixed