lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 1 Nov 2017 15:17:09 -0700 From: Bjorn Andersson <bjorn.andersson@...aro.org> To: Sudeep Holla <sudeep.holla@....com> Cc: Jassi Brar <jassisinghbrar@...il.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, Arnd Bergmann <arnd@...db.de> Subject: Re: [PATCH] mailbox: add support for doorbell/signal mode controllers On Wed 01 Nov 11:15 PDT 2017, Sudeep Holla wrote: > > 80 writel_relaxed(msg->cmd, mb->mbox_base + > MAILBOX_A2B_CMD(chans->idx)); > 81 writel_relaxed(msg->rx_size, mb->mbox_base + > > 82 MAILBOX_A2B_DAT(chans->idx)); > > 83 This is just terrible, using the void *mssg to pass a struct which is interpreted by the controller removes any form of abstraction provided by the framework. In my view the void *mssg should point to the data to be written in the mailbox register, and hence might be of different size - but only of native type. Regards, Bjorn
Powered by blists - more mailing lists