linux-kernel - Re: [PATCH] s390/ap_bus: Convert timers to use timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jLJY_zYf=v_xYUEG6tgLzwvW8P+-d9GNNp8XN5bhnWvzQ@mail.gmail.com>
Date:   Thu, 2 Nov 2017 16:36:53 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Martin Schwidefsky <schwidefsky@...ibm.com>
Cc:     Heiko Carstens <heiko.carstens@...ibm.com>,
        Harald Freudenberger <freude@...ibm.com>,
        linux-s390@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] s390/ap_bus: Convert timers to use timer_setup()

On Wed, Oct 25, 2017 at 11:38 PM, Martin Schwidefsky
<schwidefsky@...ibm.com> wrote:
> On Wed, 25 Oct 2017 03:27:37 -0700
> Kees Cook <keescook@...omium.org> wrote:
>
>> In preparation for unconditionally passing the struct timer_list pointer to
>> all timer callbacks, switch to using the new timer_setup() and from_timer()
>> to pass the timer pointer explicitly.
>>
>> Cc: Harald Freudenberger <freude@...ibm.com>
>> Cc: Martin Schwidefsky <schwidefsky@...ibm.com>
>> Cc: Heiko Carstens <heiko.carstens@...ibm.com>
>> Cc: linux-s390@...r.kernel.org
>> Signed-off-by: Kees Cook <keescook@...omium.org>
>> ---
>>  drivers/s390/crypto/ap_bus.c   | 10 +++++-----
>>  drivers/s390/crypto/ap_bus.h   |  2 +-
>>  drivers/s390/crypto/ap_queue.c |  2 +-
>>  3 files changed, 7 insertions(+), 7 deletions(-)
>
> Parked for the second part of the s390 updates for the next merge window.
> Thanks.

Thanks for getting these staged. I just wanted to check with you,
since I don't see these in -next anywhere yet:

s390: qdio: Convert timers to use timer_setup()
s390/sclp: Convert timers to use timer_setup()
s390/cio: Convert timers to use timer_setup()
s390/scsi: Convert timers to use timer_setup()
s390/ap_bus: Convert timers to use timer_setup()

Are all of these expected to land for -rc1? (Would it help to carry
them in the timer tree?) I've got tree-wide changes ready to go once
all these conversions have landed.

Thanks!

-Kees

-- 
Kees Cook
Pixel Security