lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 2 Nov 2017 12:14:03 +0100 From: Aleksandar Markovic <aleksandar.markovic@...rk.com> To: linux-mips@...ux-mips.org Cc: Aleksandar Markovic <aleksandar.markovic@...s.com>, Douglas Leung <douglas.leung@...tec.com>, Douglas Leung <douglas.leung@...s.com>, Goran Ferenc <goran.ferenc@...tec.com>, Goran Ferenc <goran.ferenc@...s.com>, James Hogan <james.hogan@...s.com>, linux-kernel@...r.kernel.org, "Maciej W. Rozycki" <macro@...tec.com>, Miodrag Dinic <miodrag.dinic@...tec.com>, Miodrag Dinic <miodrag.dinic@...s.com>, Paul Burton <paul.burton@...tec.com>, Paul Burton <paul.burton@...s.com>, Petar Jovanovic <petar.jovanovic@...s.com>, Raghu Gandham <raghu.gandham@...s.com>, Ralf Baechle <ralf@...ux-mips.org> Subject: [PATCH v3 6/8] MIPS: math-emu: Avoid an assignment within if statement condition From: Aleksandar Markovic <aleksandar.markovic@...s.com> Move invocation of fpu_emu() to be out of if statement condition. This makes code easier to follow and debug, and fixes a checkpatch warning. Signed-off-by: Aleksandar Markovic <aleksandar.markovic@...s.com> --- arch/mips/math-emu/cp1emu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/mips/math-emu/cp1emu.c b/arch/mips/math-emu/cp1emu.c index da6c1c0..9e5c880 100644 --- a/arch/mips/math-emu/cp1emu.c +++ b/arch/mips/math-emu/cp1emu.c @@ -1353,7 +1353,8 @@ static int cop1Emulate(struct pt_regs *xcp, struct mips_fpu_struct *ctx, return SIGILL; /* a real fpu computation instruction */ - if ((sig = fpu_emu(xcp, ctx, ir))) + sig = fpu_emu(xcp, ctx, ir); + if (sig) return sig; } break; -- 2.7.4
Powered by blists - more mailing lists