lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Thu,  2 Nov 2017 17:49:27 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Souvik Kumar Chakravarty <souvik.k.chakravarty@...el.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Rajneesh Bhardwaj <rajneesh.bhardwaj@...el.com>,
        Shanth Murthy <shanth.murthy@...el.com>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] platform/x86: intel_telemetry: add back linux/io.h inclusion

This one wasn't redundant after all, as shown by this randconfig
build error:

drivers/platform/x86/intel_telemetry_pltdrv.c: In function 'telem_evtlog_read':
drivers/platform/x86/intel_telemetry_pltdrv.c:900:20: error: implicit declaration of function 'readq' [-Werror=implicit-function-declaration]

We should generally include exactly the set of headers that declare
the interfaces we use, so this adds back the missing include to
get it to compile again.

Fixes: a5e50220edbd ("platform/x86: intel_telemetry: cleanup redundant headers")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 drivers/platform/x86/intel_telemetry_pltdrv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c b/drivers/platform/x86/intel_telemetry_pltdrv.c
index 678abf2e9e92..45f790a22ca2 100644
--- a/drivers/platform/x86/intel_telemetry_pltdrv.c
+++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
@@ -16,6 +16,7 @@
  * It used the PUNIT and PMC IPC interfaces for configuring the counters.
  * The accumulated results are fetched from SRAM.
  */
+#include <linux/io.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
 
-- 
2.9.0

Powered by blists - more mailing lists