linux-kernel - Re: [PATCH] platform/x86: intel_telemetry: add back linux/io.h inclusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 2 Nov 2017 18:01:58 -0700
From:   Darren Hart <dvhart@...radead.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Souvik Kumar Chakravarty <souvik.k.chakravarty@...el.com>,
        Andy Shevchenko <andy@...radead.org>,
        Rajneesh Bhardwaj <rajneesh.bhardwaj@...el.com>,
        Shanth Murthy <shanth.murthy@...el.com>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: intel_telemetry: add back linux/io.h
 inclusion

On Thu, Nov 02, 2017 at 05:49:27PM +0100, Arnd Bergmann wrote:
> This one wasn't redundant after all, as shown by this randconfig
> build error:
> 
> drivers/platform/x86/intel_telemetry_pltdrv.c: In function 'telem_evtlog_read':
> drivers/platform/x86/intel_telemetry_pltdrv.c:900:20: error: implicit declaration of function 'readq' [-Werror=implicit-function-declaration]
> 
> We should generally include exactly the set of headers that declare
> the interfaces we use, so this adds back the missing include to
> get it to compile again.

Thanks Arnd, Andy already caught this and has it queued.

-- 
Darren Hart
VMware Open Source Technology Center