linux-kernel - Re: [PATCH][net-next] net: sched: cls_bpf: use bitwise & rather than logical && on gen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171103.155501.268373482338402451.davem@davemloft.net>
Date:   Fri, 03 Nov 2017 15:55:01 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     ast@...nel.org, daniel@...earbox.net, jhs@...atatu.com,
        xiyou.wangcong@...il.com, jiri@...nulli.us, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][net-next] net: sched: cls_bpf: use bitwise & rather
 than logical && on gen_flags

From: Colin King <colin.king@...onical.com>
Date: Thu,  2 Nov 2017 20:04:12 +0000

> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently gen_flags is being operated on by a logical && operator rather
> than a bitwise & operator. This looks incorrect as these should be bit
> flag operations. Fix this.
> 
> Detected by CoverityScan, CID#1460305 ("Logical vs. bitwise operator")
> 
> Fixes: 3f7889c4c79b ("net: sched: cls_bpf: call block callbacks for offload)
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied.