linux-kernel - Re: [PATCH] bitmap: Fix optimization of bitmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87d1506pdm.fsf@concordia.ellerman.id.au>
Date:   Fri, 03 Nov 2017 13:57:09 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Matthew Wilcox <willy@...radead.org>,
        Paul Mackerras <paulus@...abs.org>,
        Matthew Wilcox <mawilcox@...rosoft.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org
Subject: Re: [PATCH] bitmap: Fix optimization of bitmap_set/clear for big-endian machines

Matthew Wilcox <willy@...radead.org> writes:

> (I don't think I can reliably send patches from outlook; sorry for
> breaking the threading)
>
> I see where we're not incrementing the failure count ... try this patch!
>
> --- 8< ---
>
> Subject: Fix bitmap optimisation tests to report errors correctly
> From: Matthew Wilcox <mawilcox@...rosoft.com>
>
> I had neglected to increment the error counter when the tests failed,
> which made the tests noisy when they fail, but not actually return an
> error code.
>
> Reported-by: Michael Ellerman <mpe@...erman.id.au>
> Signed-off-by: Matthew Wilcox <mawilcox@...rosoft.com>
> Cc: stable@...nel.org

Thanks, that works for me.

  test_bitmap: failed 31840 out of 460506 tests

cheers