linux-kernel - Re: watchdog: f71808e_wdt: mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 03 Nov 2017 09:44:26 -0500
From:   "Gustavo A. R. Silva" <garsilva@...eddedor.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Wim Van Sebroeck <wim@...ana.be>, linux-watchdog@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: watchdog: f71808e_wdt: mark expected switch fall-throughs


Quoting Guenter Roeck <linux@...ck-us.net>:

> On Thu, Nov 02, 2017 at 02:28:17PM -0500, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> Notice that in this particular case I replaced "Fall" with a proper
>> "fall through" comment, which is what GCC is expecting to find.
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
>
> Reviewed-by: Guenter Roeck <linux@...ck-us.net>
>

Thanks!

--
Gustavo A. R. Silva

>> ---
>>  drivers/watchdog/f71808e_wdt.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/watchdog/f71808e_wdt.c b/drivers/watchdog/f71808e_wdt.c
>> index 8658dba..e0678c1 100644
>> --- a/drivers/watchdog/f71808e_wdt.c
>> +++ b/drivers/watchdog/f71808e_wdt.c
>> @@ -627,7 +627,7 @@ static long watchdog_ioctl(struct file *file,  
>> unsigned int cmd,
>>
>>  		if (new_options & WDIOS_ENABLECARD)
>>  			return watchdog_start();
>> -
>> +		/* fall through */
>>
>>  	case WDIOC_KEEPALIVE:
>>  		watchdog_keepalive();
>> @@ -641,7 +641,7 @@ static long watchdog_ioctl(struct file *file,  
>> unsigned int cmd,
>>  			return -EINVAL;
>>
>>  		watchdog_keepalive();
>> -		/* Fall */
>> +		/* fall through */
>>
>>  	case WDIOC_GETTIMEOUT:
>>  		return put_user(watchdog.timeout, uarg.i);