lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3551915a-93bb-35ef-0062-e462357c9098@oracle.com>
Date:   Fri, 3 Nov 2017 09:23:35 -0700
From:   Mike Kravetz <mike.kravetz@...cle.com>
To:     Marc-André Lureau <marcandre.lureau@...hat.com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        aarcange@...hat.com, hughd@...gle.com, nyc@...omorphy.com
Subject: Re: [PATCH 3/6] hugetlb: expose hugetlbfs_inode_info in header

On 11/03/2017 09:14 AM, Marc-André Lureau wrote:
> Hi
> 
> ----- Original Message -----
>> On 10/31/2017 11:40 AM, Marc-André Lureau wrote:
>>> The following patch is going to access hugetlbfs_inode_info field from
>>> mm/shmem.c.
>>
>> The code looks fine.  However, I would prefer something different for the
>> commit message.  Perhaps something like:
>>
>> hugetlbfs inode information will need to be accessed by code in mm/shmem.c
>> for file sealing operations.  Move inode information definition from .c
>> file to header for needed access.
> 
> Ok, Does the patch get your Reviewed-by tag with that change?
> 
> thanks
> 

Yes, you can add
Reviewed-by: Mike Kravetz <mike.kravetz@...cle.com>

with an updated commit message.
-- 
Mike Kravetz

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ