linux-kernel - [RFC PATCH] scripts: checkpatch.pl: remove obsolete in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 04 Nov 2017 03:08:06 +0800
From:   "Yang Shi" <yang.s@...baba-inc.com>
To:     apw@...onical.com, joe@...ches.com
Cc:     <akpm@...ux-foundation.org>, "Yang Shi" <yang.s@...baba-inc.com>,
        <linux-kernel@...r.kernel.org>
Subject: [RFC PATCH] scripts: checkpatch.pl: remove obsolete in_atomic rule

checkpatch.pl still reports the below in_atomic warning:

WARNING: use of in_atomic() is incorrect outside core kernel code
+       if (in_atomic())

But, in_atomic() has been used outside kernel dir for a long time, and
even drivers. So, remove the obsolete rule even though they can be
ignored.

Signed-off-by: Yang Shi <yang.s@...baba-inc.com>
CC: Andrew Morton <akpm@...ux-foundation.org>
---
Not sure if removing the obsolete rule is preferred by checkpatch.pl, anyway
it sounds not make sense to keep invalid rule.

 scripts/checkpatch.pl | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 8b80bac..e8cf94f 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -6231,17 +6231,6 @@ sub process {
 			     "Using $1 should generally have parentheses around the comparison\n" . $herecurr);
 		}
 
-# whine mightly about in_atomic
-		if ($line =~ /\bin_atomic\s*\(/) {
-			if ($realfile =~ m@...ivers/@) {
-				ERROR("IN_ATOMIC",
-				      "do not use in_atomic in drivers\n" . $herecurr);
-			} elsif ($realfile !~ m@...rnel/@) {
-				WARN("IN_ATOMIC",
-				     "use of in_atomic() is incorrect outside core kernel code\n" . $herecurr);
-			}
-		}
-
 # whine about ACCESS_ONCE
 		if ($^V && $^V ge 5.10.0 &&
 		    $line =~ /\bACCESS_ONCE\s*$balanced_parens\s*(=(?!=))?\s*($FuncArg)?/) {
-- 
1.8.3.1