linux-kernel - Re: [PATCH v2] selftests/ftrace: Introduce exit_pass and exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171103161109.7848f3c3@vmware.local.home>
Date:   Fri, 3 Nov 2017 16:11:09 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     linux-kselftest@...r.kernel.org, shuah@...nel.org,
        linux-kernel@...r.kernel.org,
        Tom Zanussi <tom.zanussi@...ux.intel.com>,
        Rajvi Jingar <rajvi.jingar@...el.com>
Subject: Re: [PATCH v2] selftests/ftrace: Introduce exit_pass and exit_fail

On Sat,  4 Nov 2017 04:38:41 +0900
Masami Hiramatsu <mhiramat@...nel.org> wrote:

> --- a/tools/testing/selftests/ftrace/ftracetest
> +++ b/tools/testing/selftests/ftrace/ftracetest
> @@ -222,7 +222,14 @@ SIG_RESULT=
>  SIG_BASE=36	# Use realtime signals
>  SIG_PID=$$
>  
> +exit_pass () {
> +  exit 0
> +}
> +
>  SIG_FAIL=$((SIG_BASE + FAIL))
> +exit_fail () {
> +  exit 1

Sorry, I should have caught this before. But can you use $PASS and
$FAIL in the functions? In case we want to override them in the future?

exit_pass() {
	exit $PASS
}

exit_fail() {
	exit $FAIL
}

-- Steve