linux-kernel - Re: [PATCH] drm/amd/display: remove some unneeded code

Open Source and information security mailing list archives

Message-ID: <CADnq5_PvNnZjKA+sB7j9cS3eJj20g==W+J72DfDHmS=A-WsD6Q@mail.gmail.com>
Date:   Mon, 6 Nov 2017 16:35:32 -0500
From:   Alex Deucher <alexdeucher@...il.com>
To:     Christian Koenig <christian.koenig@....com>
Cc:     Dan Carpenter <dan.carpenter@...cle.com>,
        Alex Deucher <alexander.deucher@....com>,
        Charlene Liu <charlene.liu@....com>,
        David Airlie <airlied@...ux.ie>,
        Tony Cheng <tony.cheng@....com>,
        kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        Dmytro Laktyushkin <Dmytro.Laktyushkin@....com>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        Yongqiang Sun <yongqiang.sun@....com>,
        Harry Wentland <harry.wentland@....com>,
        Vitaly Prosyak <vitaly.prosyak@....com>
Subject: Re: [PATCH] drm/amd/display: remove some unneeded code

On Mon, Nov 6, 2017 at 6:59 AM, Christian König
<ckoenig.leichtzumerken@...il.com> wrote:
> Am 06.11.2017 um 12:44 schrieb Dan Carpenter:
>>
>> We assign "v_init = asic_blank_start;" a few lines earlier so there is
>> no need to do it again inside the if statements.  Also "v_init" is
>> unsigned so it can't be less than zero.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
>
>
> Acked-by: Christian König <christian.koenig@....com>
>

Applied.  thanks!

Alex

>>
>> diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_timing_generator.c
>> b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_timing_generator.c
>> index 1994865d4351..c7333cdf1802 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_timing_generator.c
>> +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_timing_generator.c
>> @@ -236,13 +236,10 @@ static void tgn10_program_timing(
>>         if (tg->dlg_otg_param.signal == SIGNAL_TYPE_DISPLAY_PORT ||
>>                 tg->dlg_otg_param.signal == SIGNAL_TYPE_DISPLAY_PORT_MST
>> ||
>>                 tg->dlg_otg_param.signal == SIGNAL_TYPE_EDP) {
>> -               v_init = asic_blank_start;
>>                 start_point = 1;
>>                 if (patched_crtc_timing.flags.INTERLACE == 1)
>>                         field_num = 1;
>>         }
>> -       if (v_init < 0)
>> -               v_init = 0;
>>         v_fp2 = 0;
>>         if (tg->dlg_otg_param.vstartup_start > asic_blank_end)
>>                 v_fp2 = tg->dlg_otg_param.vstartup_start > asic_blank_end;
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@...ts.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives