linux-kernel - Re: [PATCH] drm/amd/display: remove some unneeded code

Open Source and information security mailing list archives

Message-ID: <f1752f40-42fc-7c3e-38ae-50e1d3b1617b@gmail.com>
Date:   Mon, 6 Nov 2017 12:59:29 +0100
From:   Christian König <ckoenig.leichtzumerken@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Alex Deucher <alexander.deucher@....com>
Cc:     Charlene Liu <charlene.liu@....com>,
        David Airlie <airlied@...ux.ie>,
        Harry Wentland <harry.wentland@....com>,
        dri-devel@...ts.freedesktop.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org, amd-gfx@...ts.freedesktop.org,
        Dmytro Laktyushkin <Dmytro.Laktyushkin@....com>,
        Vitaly Prosyak <vitaly.prosyak@....com>,
        Yongqiang Sun <yongqiang.sun@....com>,
        Tony Cheng <tony.cheng@....com>,
        Christian König <christian.koenig@....com>
Subject: Re: [PATCH] drm/amd/display: remove some unneeded code

Am 06.11.2017 um 12:44 schrieb Dan Carpenter:
> We assign "v_init = asic_blank_start;" a few lines earlier so there is
> no need to do it again inside the if statements.  Also "v_init" is
> unsigned so it can't be less than zero.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Acked-by: Christian König <christian.koenig@....com>

>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_timing_generator.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_timing_generator.c
> index 1994865d4351..c7333cdf1802 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_timing_generator.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_timing_generator.c
> @@ -236,13 +236,10 @@ static void tgn10_program_timing(
>   	if (tg->dlg_otg_param.signal == SIGNAL_TYPE_DISPLAY_PORT ||
>   		tg->dlg_otg_param.signal == SIGNAL_TYPE_DISPLAY_PORT_MST ||
>   		tg->dlg_otg_param.signal == SIGNAL_TYPE_EDP) {
> -		v_init = asic_blank_start;
>   		start_point = 1;
>   		if (patched_crtc_timing.flags.INTERLACE == 1)
>   			field_num = 1;
>   	}
> -	if (v_init < 0)
> -		v_init = 0;
>   	v_fp2 = 0;
>   	if (tg->dlg_otg_param.vstartup_start > asic_blank_end)
>   		v_fp2 = tg->dlg_otg_param.vstartup_start > asic_blank_end;
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives