lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 6 Nov 2017 12:59:14 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Gimcuan Hui <gimcuan@...il.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>
Cc:     x86@...nel.org, kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: kvm: mmu: make kvm_mmu_clear_all_pte_masks static

On 03.11.2017 19:52, Gimcuan Hui wrote:
> The kvm_mmu_clear_all_pte_masks interface is only used by kvm_mmu_module_init
> locally, and does not need to be called by other module, make it static.
> 
> This patch cleans up sparse warning:
> symbol 'kvm_mmu_clear_all_pte_masks' was not declared. Should it be static?
> 
> Signed-off-by: Gimcuan Hui <gimcuan@...il.com>
> ---
>  arch/x86/kvm/mmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
> index 7a69cf053711..6b247d64926e 100644
> --- a/arch/x86/kvm/mmu.c
> +++ b/arch/x86/kvm/mmu.c
> @@ -367,7 +367,7 @@ void kvm_mmu_set_mask_ptes(u64 user_mask, u64 accessed_mask,
>  }
>  EXPORT_SYMBOL_GPL(kvm_mmu_set_mask_ptes);
>  
> -void kvm_mmu_clear_all_pte_masks(void)
> +static void kvm_mmu_clear_all_pte_masks(void)
>  {
>  	shadow_user_mask = 0;
>  	shadow_accessed_mask = 0;
> 

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 

Thanks,

David / dhildenb

Powered by blists - more mailing lists