linux-kernel - Re: [PATCH v2 1/2] selftests: bpf: test_kmod.sh: check if module is present in the path before insert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7ab64eed-9656-b447-ed4b-3daa1246325b@osg.samsung.com>
Date:   Mon, 6 Nov 2017 09:16:46 -0700
From:   Shuah Khan <shuahkh@....samsung.com>
To:     Naresh Kamboju <naresh.kamboju@...aro.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Shuah Khan <shuah@...nel.org>
Cc:     linux-kselftest@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        davem@...emloft.net, alexei.starovoitov@...il.com,
        netdev@...r.kernel.org, shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH v2 1/2] selftests: bpf: test_kmod.sh: check if module is
 present in the path before insert

On 11/06/2017 08:23 AM, Naresh Kamboju wrote:
> On 7 September 2017 at 14:46, Daniel Borkmann <daniel@...earbox.net> wrote:
>> On 09/07/2017 10:19 AM, naresh.kamboju@...aro.org wrote:
>>>
>>> From: Naresh Kamboju <naresh.kamboju@...aro.org>
>>>
>>> The test script works when kernel source and build module test_bpf.ko
>>> present on the machine. This patch will check if module is present in
>>> the path.
>>>
>>> Signed-off-by: Naresh Kamboju <naresh.kamboju@...aro.org>
>>
>>
>> Looks good, what changed between v1 and v2? Didn't get the cover
>> letter in case there was one. ;)
> 
> No change for 1/2 to v2 1/2. The only change was to v2 2/2.
> 
>>
>> Which tree are you targeting? There are usually a lot of changes
>> in BPF selftests going the usual route via net and net-next tree
>> as we often require to put test cases along the BPF patches. Given
>> the merge window now and given one can regard it as a fix, it's
>> net tree. I'm also ok if Shuah wants to pick it up this window as
>> test_kmod.sh hasn't been changed in quite a while, so no merge
>> conflicts expected.
> 
> I did not see any conflict for this file (selftests/bpf/test_kmod.sh)
> 
>>
>> Anyway, for the patch:
>>
>> Acked-by: Daniel Borkmann <daniel@...earbox.net>
>>
>> Thanks!
> 
> Thank you.
> 
> - Naresh

Hi Naresh,

Please rebase and resend both patches with Daniel's Acks.

thanks,
-- Shuah