linux-kernel - Re: [Part2 PATCH v7 20/38] crypto: ccp: Implement SEV_PDH_CERT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <280a3443-3268-5c11-4e7d-0d7874060730@amd.com>
Date:   Mon, 6 Nov 2017 10:16:53 -0600
From:   Brijesh Singh <brijesh.singh@....com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     brijesh.singh@....com, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Gary Hook <gary.hook@....com>,
        Tom Lendacky <thomas.lendacky@....com>,
        linux-crypto@...r.kernel.org
Subject: Re: [Part2 PATCH v7 20/38] crypto: ccp: Implement SEV_PDH_CERT_EXPORT
 ioctl command



On 11/05/2017 05:34 AM, Borislav Petkov wrote:
...

> 
> Fixes ontop:
> 
> * !input.cert_chain_address test was repeated. I saw that by aligning
> them vertically, i.e., after making it more readable, the repetition
> became obvious.
> 
> * Do the lengths checks first and the access_ok after, in each PDH and
> cert chain test.
> 
> * Do the checks first and the allocations after, not interleaved.
> 
> * Comments are sentences which should end with a '.'
> 
> (hunk below contains also that &psp_master->cmd_buf change but you're going to
>   remove that arg anyway).
> 


I am good with all your fixup, I will apply them in v8.

-Brijesh