linux-kernel - Re: [PATCH 3/6] target: Fix quiese during transport_write_pending

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <6892cffb-3734-7bd7-aa42-1d91b70ee57b@linux.vnet.ibm.com>
Date:   Wed, 8 Nov 2017 15:29:27 -0600
From:   "Bryant G. Ly" <bryantly@...ux.vnet.ibm.com>
To:     "Nicholas A. Bellinger" <nab@...ux-iscsi.org>,
        target-devel <target-devel@...r.kernel.org>
Cc:     linux-scsi <linux-scsi@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Mike Christie <mchristi@...hat.com>,
        Hannes Reinecke <hare@...e.com>,
        Michael Cyr <mikecyr@...ux.vnet.ibm.com>,
        Potnuri Bharat Teja <bharat@...lsio.com>,
        Sagi Grimberg <sagi@...mberg.me>
Subject: Re: [PATCH 3/6] target: Fix quiese during transport_write_pending_qf
 endless loop


> From: Nicholas Bellinger <nab@...ux-iscsi.org>
>
> This patch fixes a potential end-less loop during QUEUE_FULL,
> where cmd->se_tfo->write_pending() callback fails repeatedly
> but __transport_wait_for_tasks() has already been invoked to
> quiese the outstanding se_cmd descriptor.
>
> To address this bug, this patch adds a CMD_T_STOP|CMD_T_ABORTED
> check within transport_write_pending_qf() and invokes the
> existing se_cmd->t_transport_stop_comp to signal quiese
> completion back to __transport_wait_for_tasks().
>
> Cc: Mike Christie <mchristi@...hat.com>
> Cc: Hannes Reinecke <hare@...e.com>
> Cc: Bryant G. Ly <bryantly@...ux.vnet.ibm.com>
> Cc: Michael Cyr <mikecyr@...ux.vnet.ibm.com>
> Cc: Potnuri Bharat Teja <bharat@...lsio.com>
> Cc: Sagi Grimberg <sagi@...mberg.me>
> Signed-off-by: Nicholas Bellinger <nab@...ux-iscsi.org>
> ---
>
Reviewed-by: Bryant G. Ly <bryantly@...ux.vnet.ibm.com>