linux-kernel - Re: [PATCH 1/6] target: Fix QUEUE_FULL + SCSI task attribute handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <c46a9035-85fa-6322-beb5-ae38d90ccb49@linux.vnet.ibm.com>
Date:   Wed, 8 Nov 2017 15:29:45 -0600
From:   "Bryant G. Ly" <bryantly@...ux.vnet.ibm.com>
To:     "Nicholas A. Bellinger" <nab@...ux-iscsi.org>,
        target-devel <target-devel@...r.kernel.org>
Cc:     linux-scsi <linux-scsi@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Michael Cyr <mikecyr@...ux.vnet.ibm.com>,
        Mike Christie <mchristi@...hat.com>,
        Hannes Reinecke <hare@...e.com>
Subject: Re: [PATCH 1/6] target: Fix QUEUE_FULL + SCSI task attribute handling


> From: Nicholas Bellinger <nab@...ux-iscsi.org>
>
> This patch fixes a bug during QUEUE_FULL where transport_complete_qf()
> calls transport_complete_task_attr() after it's already been invoked
> by target_complete_ok_work() or transport_generic_request_failure()
> during initial completion, preceeding QUEUE_FULL.
>
> This will result in se_device->simple_cmds, se_device->dev_cur_ordered_id
> and/or se_device->dev_ordered_sync being updated multiple times for
> a single se_cmd.
>
> To address this bug, clear SCF_TASK_ATTR_SET after the first call
> to transport_complete_task_attr(), and avoid updating SCSI task
> attribute related counters for any subsequent calls.
>
> Also, when a se_cmd is deferred due to ordered tags and executed
> via target_restart_delayed_cmds(), set CMD_T_SENT before execution
> matching what target_execute_cmd() does.
>
> Cc: Michael Cyr <mikecyr@...ux.vnet.ibm.com>
> Cc: Bryant G. Ly <bryantly@...ux.vnet.ibm.com>
> Cc: Mike Christie <mchristi@...hat.com>
> Cc: Hannes Reinecke <hare@...e.com>
> Signed-off-by: Nicholas Bellinger <nab@...ux-iscsi.org>
> ---
>
Reviewed-by: Bryant G. Ly <bryantly@...ux.vnet.ibm.com>