linux-kernel - Re: [PATCH net] qmi_wwan: Add missing skb_reset_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171108.161200.1512744535172418135.davem@davemloft.net>
Date:   Wed, 08 Nov 2017 16:12:00 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     kristian.evensen@...il.com
Cc:     bjorn@...k.no, netdev@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] qmi_wwan: Add missing skb_reset_mac_header-call

From: Kristian Evensen <kristian.evensen@...il.com>
Date: Tue,  7 Nov 2017 13:47:56 +0100

> When we receive a packet on a QMI device in raw IP mode, we should call
> skb_reset_mac_header() to ensure that skb->mac_header contains a valid
> offset in the packet. While it shouldn't really matter, the packets have
> no MAC header and the interface is configured as-such, it seems certain
> parts of the network stack expects a "good" value in skb->mac_header.
> 
> Without the skb_reset_mac_header() call added in this patch, for example
> shaping traffic (using tc) triggers the following oops on the first
> received packet:
 ...
> While the oops is for a 4.9-kernel, I was able to trigger the same oops with
> net-next as of yesterday.
> 
> Signed-off-by: Kristian Evensen <kristian.evensen@...il.com>

Applied, with Fixes: tag added, and queued up for -stable.

Thanks!