linux-kernel - Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aca6237f-f430-a06d-e4b1-9a11661f3502@oracle.com>
Date:   Wed, 8 Nov 2017 09:34:54 -0600
From:   Govinda Tatti <govinda.tatti@...cle.com>
To:     Juergen Gross <jgross@...e.com>,
        Roger Pau Monné <roger.pau@...rix.com>
Cc:     xen-devel@...ts.xenproject.org, boris.ostrovsky@...cle.com,
        linux-kernel@...r.kernel.org, konrad.wilk@...cle.com
Subject: Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset
 with 'do_flr' SysFS attribute



On 11/8/2017 9:09 AM, Juergen Gross wrote:
> On 08/11/17 16:00, Govinda Tatti wrote:
>> Thanks Roger for your review comments. Please see below for my comments.
>>
>> On 11/7/2017 5:21 AM, Roger Pau Monné wrote:
>>> On Mon, Nov 06, 2017 at 12:48:42PM -0500, Govinda Tatti wrote:
>>>> +out:
>>>> +    if (!err)
>>>> +        err = count;
>>>> +
>>>> +    return err;
>>> What's the purpose of returning count here?
>> Not sure. Will check with Konrad and address this comment.
> You are telling sysfs that you have consumed all input characters.
>
Thanks Juergen

Cheers
GOVINDA