linux-kernel - Re: [PATCH v2 1/3] Input: ad7897 - use managed allocated resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171108153615.yy4gdsmc3ahr5uqu@jack.zhora.eu>
Date:   Thu, 9 Nov 2017 00:36:15 +0900
From:   Andi Shyti <andi@...zian.org>
To:     Lars-Peter Clausen <lars@...afoo.de>
Cc:     Andi Shyti <andi@...zian.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Michael Hennerich <michael.hennerich@...log.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andi Shyti <andi.shyti@...sung.com>
Subject: Re: [PATCH v2 1/3] Input: ad7897 - use managed allocated resources

> > -	ts = kzalloc(sizeof(struct ad7877), GFP_KERNEL);
> > -	input_dev = input_allocate_device();
> > -	if (!ts || !input_dev) {
> > -		err = -ENOMEM;
> > -		goto err_free_mem;
> > -	}
> > +	ts = devm_kzalloc(&spi->dev, sizeof(struct ad7877), GFP_KERNEL);
> > +	input_dev = devm_input_allocate_device(&spi->dev);
> > +	if (!input_dev)
> 
> You removed the check for 'ts' here and only added it back in patch 3.

Oh yes, because I squashed the 5 patches I sent earlier and I
forgot about this.

Thanks!

Andi