linux-kernel - Re: usb/media/em28xx: use-after-free in em28xx_dvb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAeHK+wtAhx_i3N4ONkNiqU_k=Pgk9p4dxAV9LGs4d=CPxLZcQ@mail.gmail.com>
Date:   Wed, 8 Nov 2017 16:57:08 +0100
From:   Andrey Konovalov <andreyknvl@...gle.com>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Kostya Serebryany <kcc@...gle.com>,
        syzkaller <syzkaller@...glegroups.com>
Subject: Re: usb/media/em28xx: use-after-free in em28xx_dvb_fini

On Tue, Nov 7, 2017 at 10:18 PM, Gustavo A. R. Silva
<garsilva@...eddedor.com> wrote:
> Hi Andrey,
>
> Could you please try this patch?
>
> Thank you
>
> Gustavo A. R. Silva

Hi Gustavo,

Still see the crash with your patch.

Thanks!

>
> ---
>  drivers/media/usb/em28xx/em28xx-dvb.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/usb/em28xx/em28xx-dvb.c b/drivers/media/usb/em28xx/em28xx-dvb.c
> index 4a7db62..fc3fb92 100644
> --- a/drivers/media/usb/em28xx/em28xx-dvb.c
> +++ b/drivers/media/usb/em28xx/em28xx-dvb.c
> @@ -2073,6 +2073,9 @@ static int em28xx_dvb_fini(struct em28xx *dev)
>         struct em28xx_dvb *dvb;
>         struct i2c_client *client;
>
> +       if (!dev)
> +               return 0;
> +
>         if (dev->is_audio_only) {
>                 /* Shouldn't initialize IR for this interface */
>                 return 0;
> --
> 2.7.4
>