linux-kernel - Re: usb/media/em28xx: use-after-free in em28xx_dvb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171108100301.Horde.pDKmT_QqqGyUbLr9ES3Gy9m@gator4166.hostgator.com>
Date:   Wed, 08 Nov 2017 10:03:00 -0600
From:   "Gustavo A. R. Silva" <garsilva@...eddedor.com>
To:     Andrey Konovalov <andreyknvl@...gle.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Kostya Serebryany <kcc@...gle.com>,
        syzkaller <syzkaller@...glegroups.com>
Subject: Re: usb/media/em28xx: use-after-free in em28xx_dvb_fini


Quoting Andrey Konovalov <andreyknvl@...gle.com>:

> On Tue, Nov 7, 2017 at 10:18 PM, Gustavo A. R. Silva
> <garsilva@...eddedor.com> wrote:
>> Hi Andrey,
>>
>> Could you please try this patch?
>>
>> Thank you
>>
>> Gustavo A. R. Silva
>
> Hi Gustavo,
>
> Still see the crash with your patch.
>
> Thanks!
>

Thank you, Andrey. I will look into this further.

--
Gustavo A. R. Silva

>>
>> ---
>>  drivers/media/usb/em28xx/em28xx-dvb.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/media/usb/em28xx/em28xx-dvb.c  
>> b/drivers/media/usb/em28xx/em28xx-dvb.c
>> index 4a7db62..fc3fb92 100644
>> --- a/drivers/media/usb/em28xx/em28xx-dvb.c
>> +++ b/drivers/media/usb/em28xx/em28xx-dvb.c
>> @@ -2073,6 +2073,9 @@ static int em28xx_dvb_fini(struct em28xx *dev)
>>         struct em28xx_dvb *dvb;
>>         struct i2c_client *client;
>>
>> +       if (!dev)
>> +               return 0;
>> +
>>         if (dev->is_audio_only) {
>>                 /* Shouldn't initialize IR for this interface */
>>                 return 0;
>> --
>> 2.7.4
>>