lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 8 Nov 2017 09:26:41 -0800 From: Loc Ho <lho@....com> To: Arnd Bergmann <arnd@...db.de> Cc: Alessandro Zummo <a.zummo@...ertech.it>, Alexandre Belloni <alexandre.belloni@...e-electrons.com>, Mark Brown <broonie@...aro.org>, linux-rtc@...r.kernel.org, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] rtc: x-gene: mark PM functions as __maybe_unused Hi, > The new xgene_rtc_alarm_irq_enabled() function is only accessed > from PM code, which is inside of an #ifdef; this causes a harmless > build warning when CONFIG_PM is disabled: > > drivers/rtc/rtc-xgene.c:108:12: error: 'xgene_rtc_alarm_irq_enabled' defined but not used [-Werror=unused-function] > > Just remove the #ifdef and use __maybe_unused annotations instead, > to make the code more robust here. It sounds like desire to merge in the suspend/resume support as this is in linux-next 14 hours ago. Reviewed-by: Loc Ho <lho@....com> -Loc
Powered by blists - more mailing lists