lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 9 Nov 2017 01:17:57 +0100 From: Alexandre Belloni <alexandre.belloni@...e-electrons.com> To: Arnd Bergmann <arnd@...db.de> Cc: Alessandro Zummo <a.zummo@...ertech.it>, Loc Ho <lho@....com>, Mark Brown <broonie@...aro.org>, linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] rtc: x-gene: mark PM functions as __maybe_unused On 08/11/2017 at 13:08:10 +0100, Arnd Bergmann wrote: > The new xgene_rtc_alarm_irq_enabled() function is only accessed > from PM code, which is inside of an #ifdef; this causes a harmless > build warning when CONFIG_PM is disabled: > > drivers/rtc/rtc-xgene.c:108:12: error: 'xgene_rtc_alarm_irq_enabled' defined but not used [-Werror=unused-function] > > Just remove the #ifdef and use __maybe_unused annotations instead, > to make the code more robust here. > > Fixes: 9f8f1c8b727d ("rtc: Fix suspend/resume for APM X-Gene SoC RTC driver") > Signed-off-by: Arnd Bergmann <arnd@...db.de> > --- > drivers/rtc/rtc-xgene.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Powered by blists - more mailing lists