lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 9 Nov 2017 01:18:24 +0100 From: Alexandre Belloni <alexandre.belloni@...e-electrons.com> To: Akshay Bhat <akshay.bhat@...esys.com> Cc: a.zummo@...ertech.it, linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] rtc: rx8010: Fix for incorrect return value On 08/11/2017 at 14:58:14 -0500, Akshay Bhat wrote: > The err variable is not being reset after a successful read. Explicitly > return 0 at the end of function call to account for all return paths. > > Reported-by: Jens-Peter Oswald <oswald@....de> > Signed-off-by: Akshay Bhat <akshay.bhat@...esys.com> > --- > v2: Address comments from Alexandre Belloni > - Return 0 at end of function instead of resetting err variable > > drivers/rtc/rtc-rx8010.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Powered by blists - more mailing lists