linux-kernel - Re: [PATCH V1 1/1] serial: 8250_fintek: Fix crash with baud rate B0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171108173414.7b16c796@alans-desktop>
Date:   Wed, 8 Nov 2017 17:34:14 +0000
From:   Alan Cox <gnomes@...rguk.ukuu.org.uk>
To:     "Ji-Ze Hong (Peter Hong)" <hpeter@...il.com>
Cc:     gregkh@...uxfoundation.org, jslaby@...e.com, lukas@...ner.de,
        rel+kernel@...lox.net, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org, ricardo.ribalda@...il.com,
        "Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@...il.com>
Subject: Re: [PATCH V1 1/1] serial: 8250_fintek: Fix crash with baud rate B0

On Wed,  8 Nov 2017 11:05:46 +0800
"Ji-Ze Hong (Peter Hong)" <hpeter@...il.com> wrote:

> The 8250_fintek.c is support the Fintek F81866/F81216 with dynamic clock.
> But It'll generate "division by zero" exception and crash in
> fintek_8250_set_termios() with baud rate 0 on baudrate_table[i] % baud.

0 means "hang up", so this looks good providing it leaves the device in a
sane state.


Reviewed-by: Alan Cox <alan@...ux.intel.com>