linux-kernel - Re: [PATCH v2] checkpatch: do not check missing blank line before builtin_*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 08 Nov 2017 09:35:50 -0800
From:   Joe Perches <joe@...ches.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     Paul Gortmaker <paul.gortmaker@...driver.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andy Whitcroft <apw@...onical.com>
Subject: Re: [PATCH v2] checkpatch: do not check missing blank line before
 builtin_*_driver

On Wed, 2017-11-08 at 22:32 +0900, Masahiro Yamada wrote:
> Hi Joe, Andrew,
> 
> (sorry, Andrew was missing from the list...)
> 
> 2017-09-18 11:01 GMT+09:00 Masahiro Yamada <yamada.masahiro@...ionext.com>:
> > checkpatch.pl does not check missing blank line before module_*_driver.
> > I want it to behave likewise for builtin_*_driver.
> > 
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> > ---
> > 
> > Changes in v2:
> >   - Improve the matching pattern as suggested by Joe Perches
> > 
> >  scripts/checkpatch.pl | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index dd2c262aebbf..5c6179c63cf6 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -3103,6 +3103,7 @@ sub process {
> >                       $line =~ /^\+[a-z_]*init/ ||
> >                       $line =~ /^\+\s*(?:static\s+)?[A-Z_]*ATTR/ ||
> >                       $line =~ /^\+\s*DECLARE/ ||
> > +                     $line =~ /^\+\s*builtin_[\w_]*driver/ ||
> >                       $line =~ /^\+\s*__setup/)) {
> >                         if (CHK("LINE_SPACING",
> >                                 "Please use a blank line after function/struct/union/enum declarations\n" . $hereprev) &&
> > --
> > 2.7.4
> > 
> 
> 
> Is this patch good for 4.15-rc1?
> 
> "git log scripts/checkpatch.pl" shows
> this kind of patch is generally picked up by Andrew.
> 
> 
> If Joe issues Acked-by, that will be very helpful
> for applying this patch.

Acked-by: Joe Perches <joe@...ches.com>