lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 9 Nov 2017 21:14:35 +0000 From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org> To: Vinod Koul <vinod.koul@...el.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: LKML <linux-kernel@...r.kernel.org>, ALSA <alsa-devel@...a-project.org>, Mark <broonie@...nel.org>, Takashi <tiwai@...e.de>, Pierre <pierre-louis.bossart@...ux.intel.com>, Sanyog Kale <sanyog.r.kale@...el.com>, Shreyas NC <shreyas.nc@...el.com>, patches.audio@...el.com, alan@...ux.intel.com, Charles Keepax <ckeepax@...nsource.cirrus.com>, Sagar Dharia <sdharia@...eaurora.org>, plai@...eaurora.org, Sudheer Papothi <spapothi@...eaurora.org> Subject: Re: [PATCH 10/14] soundwire: Add sysfs for SoundWire DisCo properties On 19/10/17 04:03, Vinod Koul wrote: > It helps to read the properties for understanding and debug > SoundWire systems, so add sysfs files for SoundWire DisCo > properties. > > TODO: Add ABI files for sysfs > > Signed-off-by: Sanyog Kale <sanyog.r.kale@...el.com> > Signed-off-by: Vinod Koul <vinod.koul@...el.com> > --- > diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c > index 6c4f41b64744..e3d7aea18892 100644 > --- a/drivers/soundwire/bus.c > +++ b/drivers/soundwire/bus.c > @@ -90,6 +90,8 @@ int sdw_add_bus_master(struct sdw_bus *bus) > } > } > > + sdw_sysfs_bus_init(bus); > + > /* > * SDW is an enumerable bus, but devices can be powered off. So, > * they won't be able to report as present. > @@ -119,6 +121,8 @@ static int sdw_delete_slave(struct device *dev, void *data) > struct sdw_slave *slave = dev_to_sdw_dev(dev); > struct sdw_bus *bus = slave->bus; > > + sdw_sysfs_slave_exit(slave); > + > mutex_lock(&bus->bus_lock); > if (!list_empty(&bus->slaves)) > list_del(&slave->node); > @@ -130,6 +134,7 @@ static int sdw_delete_slave(struct device *dev, void *data) > > void sdw_delete_bus_master(struct sdw_bus *bus) > { > + sdw_sysfs_bus_init(bus); Shouldn't this be sdw_sysfs_bus_exit() here? > device_for_each_child(bus->dev, NULL, sdw_delete_slave); > }
Powered by blists - more mailing lists