linux-kernel - Re: [PATCH v2] s390/virtio: mark headers as BSD licensed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171109095737.6a3082f7.cohuck@redhat.com>
Date:   Thu, 9 Nov 2017 09:57:37 +0100
From:   Cornelia Huck <cohuck@...hat.com>
To:     Christian Borntraeger <borntraeger@...ibm.com>
Cc:     "Michael S. Tsirkin" <mst@...hat.com>,
        linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        linux-s390@...r.kernel.org
Subject: Re: [PATCH v2] s390/virtio: mark headers as BSD licensed

On Thu, 9 Nov 2017 09:29:32 +0100
Christian Borntraeger <borntraeger@...ibm.com> wrote:

> On 11/08/2017 08:58 PM, Michael S. Tsirkin wrote:
> > On Wed, Nov 08, 2017 at 08:39:11PM +0100, Christian Borntraeger wrote:  
> >>
> >>
> >> On 11/08/2017 08:35 PM, Michael S. Tsirkin wrote:  
> >>> On Wed, Nov 08, 2017 at 07:57:28PM +0100, Christian Borntraeger wrote:  
> >>>> So what about the following
> >>>>
> >>>> - leave kvm_virtio.h unchanged and we will delete this file via the s390 tree  
> >>>
> >>> Seems to be used by kvm_virtio.c - are you removing that too?  
> >>
> >> Yes, so sorry my first url for the git.kernel.org was in the wrong subfolder:
> >> https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git/commit?h=features&id=7fb2b2d512448cf0e914c4647a1cf02b52263702
> >>
> >>  
> >>>  
> >>>> - change virtio_ccw.h to BSD license. The content of this file is really really trivial
> >>>> and it boils down to 2 defines, that can be easily reconstructed by looking at the virtio spec.
> >>>> Not even sure if something like this can be copyrighted.  
> >>>
> >>> Yes. What prompted this was Greg's patch.
> >>>  
> >>>>
> >>>> For reference the content of this file minus comments is
> >>>>
> >>>> - snip -
> >>>> #define KVM_VIRTIO_CCW_RING_ALIGN 4096
> >>>> #define KVM_S390_VIRTIO_CCW_NOTIFY 3
> >>>> - snip -
> >>>>
> >>>>  
> >>
> >> [..]  
> > 
> > 
> > So for ccw if both you and Cornelia ACK, we'll be fine I think.
> > No one else touched this code.  
> 
> A patch that changes virtio_ccw.h to a dual gpl2/bsd licence is
> 
> Acked-by: Christian Borntraeger <borntraeger@...ibm.com>
> 
> as it matches the original intent of the virtio header relicensing
> from 2008 while at the same time covers the fact that the whole 
> kernel is GPL2.
> 

FWIW, that would be

Acked-by: Cornelia Huck <cohuck@...hat.com>

as well (I wrote the header, but any copyright is with IBM).